Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spotify: 1.0.64.401.g9d720389-21 -> 1.0.64.407.g9bd02c2d-26 #30009

Merged
merged 1 commit into from Oct 2, 2017
Merged

spotify: 1.0.64.401.g9d720389-21 -> 1.0.64.407.g9bd02c2d-26 #30009

merged 1 commit into from Oct 2, 2017

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Oct 2, 2017 •
edited

Motivation for this change

Upstream only seems to keep the latest release file, so rebuilding fails now on stable branches. I tested it against the 17.09 stable branch.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@utdemir @Moredread
spotify: 1.0.64.401.g9d720389-21 -> 1.0.64.407.g9bd02c2d-26
c4aec67 
Upstream only seems to keep the latest release file.

(cherry picked from commit cd490dc)
@orivej orivej merged commit 7c8226d into NixOS:release-17.09 Oct 2, 2017
@orivej
Copy link
Contributor

orivej commented Oct 2, 2017

Thank you!

@Moredread Moredread deleted the release-17.09-fix/spotify branch October 6, 2017 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Moredread @orivej @utdemir