New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minio: 20170613 -> 2017-09-29T19-16-56Z #29994
Conversation
pkgs/servers/minio/default.nix
Outdated
shortVersion = "20170613"; | ||
longVersion = "2017-06-13T19-01-01Z"; | ||
shortVersion = "20170805"; | ||
longVersion = "2017-08-05T00-00-53Z"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you delete shortVersion
and rename longVersion
to version
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new version now only uses the long version which is now called version
pkgs/servers/minio/default.nix
Outdated
shortVersion = "20170613"; | ||
longVersion = "2017-06-13T19-01-01Z"; | ||
shortVersion = "20170805"; | ||
longVersion = "2017-08-05T00-00-53Z"; | ||
|
||
src = fetchurl { | ||
url = "https://github.com/minio/minio/archive/RELEASE.${lib.replaceStrings [":"] ["-"] longVersion}.tar.gz"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replaceStrings
is not needed, just use ${version}
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
The test was updated as minio now needs at least 1 GiB of free disk, otherwise it won't start.
|
||
shortVersion = "20170613"; | ||
longVersion = "2017-06-13T19-01-01Z"; | ||
version = "2017-09-29T19-16-56Z"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a weird version scheme. Only milliseconds are missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it allows for a pretty rapid release cycle 😉
Motivation for this change
Update to lastest version: CHANGELOG
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)