Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd2: 0.6.8 -> 0.7.7 #30012

Merged
merged 1 commit into from Oct 2, 2017
Merged

cmd2: 0.6.8 -> 0.7.7 #30012

merged 1 commit into from Oct 2, 2017

Conversation

teto
Copy link
Member

@teto teto commented Oct 2, 2017

Motivation for this change

had problems running it on python3.6

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@teto teto requested a review from FRidh as a code owner October 2, 2017 03:30
@orivej orivej merged commit 4bc9b84 into NixOS:master Oct 2, 2017
@teto teto deleted the cmd2 branch October 2, 2017 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teto @orivej