Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gmsh: 2.12.0 -> 3.0.5 #29859

Merged
merged 1 commit into from Oct 1, 2017
Merged

gmsh: 2.12.0 -> 3.0.5 #29859

merged 1 commit into from Oct 1, 2017

Conversation

pvgoran
Copy link
Contributor

@pvgoran pvgoran commented Sep 27, 2017

Motivation for this change

This fixes building of the gmsh package that was broken on gcc 6 (due to more strict handling of signed vs. unsigned char conversions, I assume).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@pvgoran
Copy link
Contributor Author

pvgoran commented Sep 27, 2017

#28643

@orivej orivej merged commit eaf9e31 into NixOS:master Oct 1, 2017
@pvgoran pvgoran deleted the fix-gmsh branch October 1, 2017 09:20
@pvgoran
Copy link
Contributor Author

pvgoran commented Oct 4, 2017

How about backporting it to release-17.09? One less broken package this way.

@orivej
Copy link
Contributor

orivej commented Oct 4, 2017

Would you open a pull request for release-17.09 and confirm that it builds?

@pvgoran
Copy link
Contributor Author

pvgoran commented Oct 4, 2017

I was building it with release-17.09 from the beginning (as suggested by nixpkgs manual). So building with 17.09 is already confirmed.

I suppose I need to remove the package from the list of broken packages with the same PR. Where do I do it?

@orivej
Copy link
Contributor

orivej commented Oct 4, 2017

I think this is good enough, cherry picked into release in 5dbe7eb

There is no list of broken packages. Packages are marked broken with a broken key in their meta, but this one was not.

@orivej
Copy link
Contributor

orivej commented Oct 4, 2017

Oops, it was. Unmarked in f86ae37

@pvgoran
Copy link
Contributor Author

pvgoran commented Oct 4, 2017

Ok, good.

@grahamc
Copy link
Member

grahamc commented Oct 6, 2017

@orivej Hi, nice to see you merging and backporting! When you cherrypick to stable make sure to cherry-pick with -x. See: https://nixos.org/nixpkgs/manual/#idm140737317012192 As a side note, what is your IRC nick?

@orivej
Copy link
Contributor

orivej commented Oct 6, 2017

@grahamc Yeah, this was my first pick, I noticed that it lacks the reference and used -x in all future picks. My nick is orivej.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pvgoran @orivej @grahamc