Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul service: Restart on failure #29860

Merged
merged 1 commit into from Sep 27, 2017
Merged

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Sep 27, 2017

Motivation for this change

Consul is a service you typically want to have running all the time; it's not supposed to quit by itself.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

CC @wkennington @offlinehacker @edef1c @kamilchm @aszlig @jagajaga because you have made updates to the consul service in the past and may be interested.


I have tested this change on my production consul cluster.

Consul is a service you typically want to have running all the time;
it's not supposed to quit by itself.
@nh2
Copy link
Contributor Author

nh2 commented Sep 27, 2017

Once this is merged I'd like to backport it on 17.09; PR #29861 is for that.

nh2 added a commit to nh2/nixops-gluster-example that referenced this pull request Sep 27, 2017
@fpletz fpletz merged commit f4c53f1 into NixOS:master Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants