Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urweb: support darwin, depend on gcc, fix paths. #29857

Merged
merged 1 commit into from Sep 27, 2017
Merged

urweb: support darwin, depend on gcc, fix paths. #29857

merged 1 commit into from Sep 27, 2017

Conversation

peterbb
Copy link
Contributor

@peterbb peterbb commented Sep 27, 2017 •
edited

Motivation for this change
  1. Add support for the darwing platform.
  2. Make the urweb-compiler usable without manually installing dependencies and fiddling with arguments.
Things done

Tested on macOS Sierra (v 10.12) and NixOS 18.03pre116475.d757d8142e (Impala).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@peterbb
urweb: support darwin, depend on gcc, fix paths.
76245e0 
1. Add support for the darwing platform.
2. Depend on gcc, since the urweb executable will
   call gcc when it compiles an urweb-project.
3. Fix include path and link path for the dependencies.
@thoughtpolice
Copy link
Member

Thanks for this! LGTM.

@thoughtpolice thoughtpolice merged commit 04d449a into NixOS:master Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterbb @thoughtpolice @Janik-Haag