Skip to content

Commit

Permalink
Revert "ibus: Move ibus-setup to .dev"
Browse files Browse the repository at this point in the history 
This reverts commit af44f99.

ibus-with-plugins was broken by this.

cc @edolstra
  • Loading branch information
@globin
globin committed Sep 27, 2017
1 parent 21998d5 commit e0771a2
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions pkgs/tools/inputmethods/ibus/default.nix
View file
Expand Up @@ -110,10 +110,6 @@ in stdenv.mkDerivation rec {
doInstallCheck = true;
installCheckPhase = "$out/bin/ibus version";

postInstall = ''
moveToOutput "bin/ibus-setup" "$dev"
'';

meta = with stdenv.lib; {
homepage = https://github.com/ibus/ibus;
description = "Intelligent Input Bus for Linux / Unix OS";
Expand Down

3 comments on commit e0771a2

@edolstra
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why revert this on master? That way we'll never get rid of these -dev paths in closures.

@globin
Copy link
Member Author

@globin globin commented on e0771a2 Sep 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer committing stuff like this when it does not break dependencies. I am not sure how to fix ibus-with-plugins after this change, not knowing how ibus works and what these changes imply.

The other failures caused by postgresql I've fixed properly but I did not know how to fix this and this doesn't seem like something that should be lying around broken on master either.

@edolstra
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that ibus-setup is broken anyway:

$ ./result/bin/ibus-setup 
Traceback (most recent call last):
  File "/nix/store/ncx6vjf607q0rr7ggdywgwfsl7dbcf5w-ibus-1.5.16/share/ibus/setup/main.py", line 38, in <module>
    gi_require_version('IBus', '1.0')
  File "/nix/store/wn22bw3a44zva0w4ffsql1lhivr65633-python3-3.6.2-env/lib/python3.6/site-packages/gi/__init__.py", line 118, in require_version
    raise ValueError('Namespace %s not available' % namespace)
ValueError: Namespace IBus not available

Please sign in to comment.