Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notmuch-bower: init at 2017-09-27 #29856

Merged
merged 3 commits into from Oct 14, 2017
Merged

notmuch-bower: init at 2017-09-27 #29856

merged 3 commits into from Oct 14, 2017

Conversation

erictapen
Copy link
Member

@erictapen erictapen commented Sep 27, 2017 •
edited

Motivation for this change

This adds the bower MUA, which I may use in the future.

The reason why I didn't use the latest version 0.8 but the most recent commit wangp/bower@ff95a1e is, that this commit introduces man pages. Therefore, the package version 2017-08-05 is the date of that commit.

Things done

Added bower package and added erictapen as maintainer.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@erictapen
Copy link
Member Author

I't looks like, I messed something up in the rebase process; zimbatm is listed as an author. I will try to edit the commit metadata, please don't merge yet.

@erictapen
Copy link
Member Author

Now it looks good...

@Mic92 Mic92 changed the title bower: init and add erictapen as maintainer bower: init at 2017-08-05 Sep 29, 2017
@orivej
Copy link
Contributor

orivej commented Oct 1, 2017

I've improved your package in 61bb2d4

I have one reservation: it seems that adding this under the name of bower will confuse a lot of people who will want to install JS bower. May we rename it to bower-mail or notmuch-bower?

@erictapen
Copy link
Member Author

@orivej Thanks for the fixup. I learned quite a few things in it. Also a good idea to include the latest commit in order to prevent that patchShebang workaround.

This builds and works for me.

@orivej
Copy link
Contributor

orivej commented Oct 2, 2017

@erictapen And what do you think about the name of the package?

@erictapen
Copy link
Member Author

@orivej Ah right, forgot about that. I'd rather see it as bower, since the other notmuch MUAs alotand astroid also have just their names as package names.

But I'm not familiar with the popularity of JS bower. If you feel like people will confuse it easily, I'd say it's notmuch-bower (since the use case is bound tight to the notmuch system).

Would you mind taking the choice? I can do the change, based on your decision.

@Mic92
Copy link
Member

Mic92 commented Oct 13, 2017

notmuch-bower

@erictapen
Copy link
Member Author

I didn't adapt the first commit, as I can't apply @orivej's fixup after that.

@erictapen erictapen changed the title bower: init at 2017-08-05 notmuch-bower: init at 2017-09-27 Oct 14, 2017
@Mic92 Mic92 merged commit 5cca880 into NixOS:master Oct 14, 2017
@erictapen erictapen deleted the bower-init branch October 14, 2017 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erictapen @orivej @Mic92