Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tinc: remove /dev/net/tun from default configuration #29853

Merged
merged 2 commits into from Sep 27, 2017

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Sep 27, 2017

Motivation for this change
Device = /dev/net/tun

In tinc.conf seems break in combination with virtualbox host driver?
Removing it works flawless and it should not be necessary since tinc is smart enough to figure it out on its own.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

tinc can figure this out based on DeviceType.
I also got `/dev/net/tun FD in bad state` after a particular upgrade.
ExecStart is sufficient and more transparent to the user.
@Mic92 Mic92 changed the title Tinc Tinc: remove /dev/net/tun from default configuration Sep 27, 2017
@Mic92 Mic92 changed the title Tinc: remove /dev/net/tun from default configuration nixos/tinc: remove /dev/net/tun from default configuration Sep 27, 2017
@globin globin merged commit 75ba415 into NixOS:master Sep 27, 2017
@Mic92 Mic92 deleted the tinc branch September 27, 2017 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants