Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcolor3: init at 2.2 #30069

Merged
merged 1 commit into from Oct 4, 2017
Merged

gcolor3: init at 2.2 #30069

merged 1 commit into from Oct 4, 2017

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 3, 2017

Motivation for this change

Fueh

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar force-pushed the gcolor3 branch 2 times, most recently from d1f0e3a to fc1beee Compare October 3, 2017 22:42
homepage = https://hjdskes.github.io/projects/gcolor3/;
license = stdenv.lib.licenses.gpl2;
maintainers = with stdenv.lib.maintainers; [ jtojnar ];
platforms = stdenv.lib.platforms.unix;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not build on macOS: https://travis-ci.org/NixOS/nixpkgs/jobs/282964506
You can limit the platforms to Linux.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@orivej orivej merged commit dea58ce into NixOS:master Oct 4, 2017
@jtojnar jtojnar deleted the gcolor3 branch October 4, 2017 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants