Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stupidterm: init at 20170315-752316a #29779

Closed
wants to merge 1 commit into from
Closed

Conversation

etu
Copy link
Contributor

@etu etu commented Sep 25, 2017

Motivation for this change

Stupidterm is a simple and fast VTE-Based terminal emulator which is
configured by a simple ini-file.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Stupidterm is a simple and fast VTE-Based terminal emulator which is
configured by a simple ini-file.
meta = with stdenv.lib; {
description = "Simple wrapper around the VTE terminal emulator widget for GTK+";
longDescription = ''
Simple wrapper around the VTE terminal emulator widget for GTK+
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually see that longDescription ends with a period (i.e. has full sentences and stuff). Don't think there is any recommendation though.

@etu
Copy link
Contributor Author

etu commented Sep 26, 2017

@Mic92 What happened to my signature there?

@Mic92
Copy link
Member

Mic92 commented Sep 26, 2017

@etu
Copy link
Contributor Author

etu commented Sep 26, 2017

I see, you could have told me and I would have updated it and learn something from it instead of removing my signature.

Oh well. Now it's in there at least.

@Mic92
Copy link
Member

Mic92 commented Sep 26, 2017

I usually have added a separated commit here, but you disabled commit access to maintainers.

@etu etu deleted the stupidterm branch September 29, 2017 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants