Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networkd: also load builtin modules #29768

Merged
merged 1 commit into from Mar 1, 2018
Merged

networkd: also load builtin modules #29768

merged 1 commit into from Mar 1, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Sep 25, 2017

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej
Copy link
Contributor

orivej commented Sep 29, 2017

What will change as the result?

@Mic92
Copy link
Member Author

Mic92 commented Sep 29, 2017

Systemd comes with default units for systemd-nspawn interfaces:

lrwxrwxrwx  54 root 29 Sep  9:55 80-container-host0.network -> /etc/static/systemd/network/80-container-host0.network
lrwxrwxrwx  51 root 29 Sep  9:55 80-container-ve.network -> /etc/static/systemd/network/80-container-ve.network
lrwxrwxrwx  51 root 29 Sep  9:55 80-container-vz.network -> /etc/static/systemd/network/80-container-vz.network
lrwxrwxrwx  43 root 29 Sep  9:55 99-default.link -> /etc/static/systemd/network/99-default.link

However I currently chase down a NixOS-specific bug, where Driver=veth never matches.

@peterhoeg
Copy link
Member

This is an off-topic comment admittedly, but neat trick with attrNames and readDir - I hadn't thought of that pattern but can easily see where that will make things much cleaner. Thanks @Mic92!

@Mic92
Copy link
Member Author

Mic92 commented Mar 1, 2018

The bug in systemd still exists, but I know why. So lets merge it.

@Mic92 Mic92 merged commit 1242214 into NixOS:master Mar 1, 2018
@Mic92 Mic92 deleted the networkd branch March 1, 2018 09:16
@vcunat
Copy link
Member

vcunat commented Mar 3, 2018 •
edited

@Mic92: stable network interfaces got broken by this commit (or the test): https://hydra.nixos.org/build/70356440 I haven't yet looked into the real reasons.

@Mic92
Copy link
Member Author

Mic92 commented Mar 4, 2018

@vcunat ah, I have to rethink this. #33617 would be also required for this.

@Mic92
Copy link
Member Author

Mic92 commented Mar 4, 2018

reverted in a5dcde1 for the time beeing

coreyoconnor pushed a commit to coreyoconnor/nixpkgs that referenced this pull request Mar 4, 2018
@Mic92
Revert "networkd: also load builtin modules"
a5dcde1 
This reverts commit d514dc2.

breaks unpredicable network interfaces: NixOS#29768 (comment)
@Mic92 Mic92 mentioned this pull request Apr 23, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mic92 @orivej @peterhoeg @vcunat