Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim-plugins: add install hooks #29773

Merged
merged 2 commits into from Sep 26, 2017
Merged

vim-plugins: add install hooks #29773

merged 2 commits into from Sep 26, 2017

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Sep 25, 2017

Motivation for this change
  • these hooks are helpful for custom nix code in VIM plugin expressions
  • document NIX_PATH usage (see the commit message for further reference)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@@ -16,7 +16,7 @@ in

# TL;DR
# Add your plugin to ./vim-plugin-names
# Regenerate via `nix-shell -p vimPlugins.pluginnames2nix --command "vim-plugin-names-to-nix"`
# Regenerate via `NIX_PATH=nixpkgs=/path/to/your/local/fork nix-shell -p vimPlugins.pluginnames2nix --command "vim-plugin-names-to-nix"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think nix-shell -I nixpkgs=/path/to/nixpkgs ... also works

@Ma27
Copy link
Member Author

Ma27 commented Sep 25, 2017

@LnL7 done :)

…ix` usage

I use my own fork for NixOS development/testing, but `nixos-unstable`
for my system configuration.

Whenever I add a new plugin and I regenerate the expressions I need to
change the `NIX_PATH` variable to my own fork. As this is something I
tend to forget I think it's better to document this.
@Mic92 Mic92 merged commit aea7320 into NixOS:master Sep 26, 2017
@Ma27 Ma27 deleted the vim/install-hooks branch September 26, 2017 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants