Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix-channel: remind user to update after adding #1578

Closed

Conversation

lheckemann
Copy link
Member

This reduces the likelihood of a common pitfall; I've often forgotten to run --update after adding a channel or changing a channel URL.

@edolstra
Copy link
Member

Arguably this violates the Unix philosophy of not spamming the user with non-error messages: http://www.faqs.org/docs/artu/ch11s09.html

@lheckemann
Copy link
Member Author

lheckemann commented Sep 25, 2017

  • interoperability: it's on standard error and I don't think nix-channel --add has any machine-readable output anyway so it shouldn't break anything in that respect
  • vertical screen space: it's a single line
  • bandwidth: not really applicable here as it's a practically instantaneous operation

Personally I've found myself forgetting to update channels after modifying them frequently enough that to me this change is justified; @infinisil had the idea after a newbie came asking, having the same issue, on IRC. I won't insist on the change, but personally think it would be for the better.

@edolstra
Copy link
Member

Unnecessary messages harm composability. For example, a script that does nix-channel --add; nix-channel --update will still print Remember to run nix-channel --update, thereby confusing the user.

@lheckemann lheckemann closed this Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants