Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

facter: 3.7.1 -> 3.9.0 and related deps #29769

Merged
merged 4 commits into from Sep 29, 2017
Merged

facter: 3.7.1 -> 3.9.0 and related deps #29769

merged 4 commits into from Sep 29, 2017

Conversation

womfoo
Copy link
Member

@womfoo womfoo commented Sep 25, 2017

Motivation for this change
  • bump to latest upstream
  • add new libwhereami package
  • update dependencies
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@womfoo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @globin, @fpletz and @obadz to be potential reviewers.

@orivej
Copy link
Contributor

orivej commented Sep 29, 2017

Thank you! I have added enableParallelBuilding for faster compilation.

@orivej orivej merged commit d1d4b7f into NixOS:master Sep 29, 2017
@womfoo womfoo deleted the bump/facter-3.9.0 branch February 3, 2018 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@womfoo @mention-bot @orivej