Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pythonPackages.root_numpy, bump python2Packages.rootpy #30780

Merged
merged 2 commits into from Oct 25, 2017
Merged

add pythonPackages.root_numpy, bump python2Packages.rootpy #30780

merged 2 commits into from Oct 25, 2017

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Oct 24, 2017

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@veprbl veprbl requested a review from FRidh as a code owner October 24, 2017 23:12
@Mic92
Copy link
Member

Mic92 commented Oct 25, 2017

I get a test failure for python36Packages.root_numpy

======================================================================
ERROR: root_numpy (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: root_numpy
Traceback (most recent call last):
  File "/nix/store/2lb6nn8ivk1alhckv43n7734lqwbw7h9-python3-3.6.2/lib/python3.6/unittest/loader.py", line 462, in _find_test_path
    package = self._get_module_from_name(name)
  File "/nix/store/2lb6nn8ivk1alhckv43n7734lqwbw7h9-python3-3.6.2/lib/python3.6/unittest/loader.py", line 369, in _get_module_from_name
    __import__(name)
  File "/tmp/nix-build-python3.6-root_numpy-4.7.3.drv-0/root_numpy-4.7.3/root_numpy/__init__.py", line 21, in <module>
    ROOT_VERSION = root_version_active()
  File "/tmp/nix-build-python3.6-root_numpy-4.7.3.drv-0/root_numpy-4.7.3/root_numpy/setup_utils.py", line 111, in root_version_active
    import ROOT
  File "/nix/store/j2bzxvy45331h8319dxs5ziyhrkq8i2w-root-6.10.08/lib/ROOT.py", line 24, in <module>
    import cppyy
  File "/nix/store/j2bzxvy45331h8319dxs5ziyhrkq8i2w-root-6.10.08/lib/cppyy.py", line 61, in <module>
    import libPyROOT as _backend
ImportError: dynamic module does not define module export function (PyInit_libPyROOT)
----------------------------------------------------------------------
Ran 1 test in 0.000s
FAILED (errors=1)

vyp
vyp reviewed Oct 25, 2017
View reviewed changes
pkgs/development/python-modules/rootpy/default.nix Outdated

meta = with lib; {
homepage = http://www.rootpy.org;
license = licenses.gpl3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did you get this? https://github.com/rootpy/rootpy/blob/1.0.1/LICENSE is bsd3.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vyp They've changed license. Thanks!

@Mic92 Mic92 merged commit aaebcef into NixOS:master Oct 25, 2017
@veprbl
Copy link
Member Author

veprbl commented Oct 25, 2017

Thanks guys!

@veprbl veprbl deleted the rootpy_1.0.1 branch December 1, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyp vyp vyp left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@veprbl @Mic92 @vyp @FRidh