Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

robo3t: change .desktop name #30776

Merged
merged 1 commit into from Oct 28, 2017
Merged

robo3t: change .desktop name #30776

merged 1 commit into from Oct 28, 2017

Conversation

emanueleperuffo
Copy link
Contributor

Motivation for this change

Gnome does not permit to add the application to favorites if the .desktop name is different than the binary name.
See https://unix.stackexchange.com/questions/58824/how-do-i-add-eclipse-to-my-gnome-shell-favorites.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@emanueleperuffo
robo3t: change .desktop name
f402c3a 
Gnome does not permit to add the application to favorites if the .desktop name is different than the binary name.
See https://unix.stackexchange.com/questions/58824/how-do-i-add-eclipse-to-my-gnome-shell-favorites.
@teto
Copy link
Member

teto commented Oct 25, 2017

why would gnome-shell do that ? seems like a pain...

@emanueleperuffo
Copy link
Contributor Author

I have no idea!

You can test it yourself if you have gnome.
You'll notice that when you open Robo3T and right click on it's dock icon there's no 'Add to Favorites'.

Now try to copy /run/current-system/sw/share/applications/Robo3T.desktop to ~/.local/share/applications/robo3t.desktop and restart gnome-shell.

Now there are 2 icons in gnome. Open the right one. I have tried both because I couldn't distinguish.
You'll notice that when you right click the dock icon you can now see 'Add to Favorites'.

To be sure this happens for real, rename ~/.local/share/applications/robo3t.desktop to ~/.local/share/applications/Robo3T.desktop and restart gnome-shell.

Now open again the right Robo3T application, or try both.
You'll notice that when you right click on dock there's no 'Add to Favorites' again.

@joachifm joachifm merged commit 722fdbe into NixOS:master Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emanueleperuffo @teto @joachifm