Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skktools: init at 1.3.3 #30778

Merged
merged 2 commits into from Oct 28, 2017
Merged

skktools: init at 1.3.3 #30778

merged 2 commits into from Oct 28, 2017

Conversation

yuriaisaka
Copy link
Contributor

@yuriaisaka yuriaisaka commented Oct 24, 2017 •
edited

Motivation for this change

skktools is a collection of tools to manipulate (merge, sort etc.)
dictionaries formatted for SKK Japanese input method.

The main motivation for having skktools in nixpkgs comes from the desire to have
fcitx-skk in fcitx-engines, which depends on libskk
(https://github.com/ueno/libskk), which in turn has a (mild build time) dependency on a
tool like skktools for preparation of a default dictionary.
(Technically, libskk can be built without skktools, but is virtually useless without
a preprocessor for publicly available dictionaries.)

Further pull requests are planned for libskk and fcitx-skk (a fcitx engine) as
well as some standard dictionaries that can be used by libskk and/or fcitx-skk.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Oct 25, 2017 •
edited

@GrahamcOfBorg skktools

GrahamcOfBorg
GrahamcOfBorg reviewed Oct 25, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

these derivations will be built:
  /nix/store/6yciildlcq656qrifwwzp5chq66fhvwr-skktools-c8816fe720604d4fd79f3552e99e0430ca6f2769-src.drv
  /nix/store/gc8r7ny3jcg8mdzvv2mr7wym7jlw9hvk-skktools.drv
building path(s) ‘/nix/store/wf2gbk5yqmsw59za70jzh7sdhvz2c5dq-skktools-c8816fe720604d4fd79f3552e99e0430ca6f2769-src’

trying https://github.com/skk-dev/skktools/archive/c8816fe720604d4fd79f3552e99e0430ca6f2769.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   158    0   158    0     0    158      0 --:--:-- --:--:-- --:--:--   644

100  283k    0  283k    0     0   283k      0 --:--:-- --:--:-- --:--:--  283k
unpacking source archive /tmp/nix-build-skktools-c8816fe720604d4fd79f3552e99e0430ca6f2769-src.drv-0/c8816fe720604d4fd79f3552e99e0430ca6f2769.tar.gz
building path(s) ‘/nix/store/jw6i49gcrx2bqsgmn14zc2s4ipqg0rav-skktools’
unpacking sources
unpacking source archive /nix/store/wf2gbk5yqmsw59za70jzh7sdhvz2c5dq-skktools-c8816fe720604d4fd79f3552e99e0430ca6f2769-src
source root is skktools-c8816fe720604d4fd79f3552e99e0430ca6f2769-src
patching sources
configuring
fixing libtool script ./ltmain.sh
configure flags: --disable-static --disable-dependency-tracking --prefix=/nix/store/jw6i49gcrx2bqsgmn14zc2s4ipqg0rav-skktools
checking for a BSD-compatible install... /nix/store/8qh2yq93x7ijvkvrf9gi0jhxr8jwh341-coreutils-8.28/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /nix/store/8qh2yq93x7ijvkvrf9gi0jhxr8jwh341-coreutils-8.28/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking for style of include used by make... GNU
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... none
checking how to run the C preprocessor... gcc -E
checking for grep that handles long lines and -e... /nix/store/sdz6f70558njbvv005a5acp8wz1jq7xi-gnugrep-3.1/bin/grep
checking for egrep... /nix/store/sdz6f70558njbvv005a5acp8wz1jq7xi-gnugrep-3.1/bin/grep -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking minix/config.h usability... no
checking minix/config.h presence... no
checking for minix/config.h... no
checking whether it is safe to define __EXTENSIONS__... yes
checking for gawk... (cached) gawk
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking dependency style of gcc... (cached) none
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking how to print strings... printf
checking for a sed that does not truncate output... /nix/store/fnd9290qsby769l8zmh982yrcmxc5qj8-gnused-4.4/bin/sed
checking for fgrep... /nix/store/sdz6f70558njbvv005a5acp8wz1jq7xi-gnugrep-3.1/bin/grep -F
checking for ld used by gcc... ld
checking if the linker (ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... nm
checking the name lister (nm) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking for ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for ar... ar
checking for strip... strip
checking for ranlib... ranlib
checking command to parse nm output from gcc object... ok
./configure: line 6749: /usr/bin/file: No such file or directory
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... no
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (ld) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... no
checking whether make sets $(MAKE)... (cached) yes
checking for bzip2... /nix/store/migmjb53v38qrjxa0bb6v3wmrwpv7d2y-bzip2-1.0.6.0.1-bin/bin/bzip2
checking for date... /nix/store/8qh2yq93x7ijvkvrf9gi0jhxr8jwh341-coreutils-8.28/bin/date
checking for gzip... /nix/store/42y51bqv59l4x5dlr0j9c13n9vbsd7cd-gzip-1.8/bin/gzip
checking for md5... no
checking for md5sum... /nix/store/8qh2yq93x7ijvkvrf9gi0jhxr8jwh341-coreutils-8.28/bin/md5sum
checking for tar... /nix/store/q6nivamar2h6havsq73iyhcdnfd5jw7h-gnutar-1.29/bin/tar
checking for mkdtemp... yes
checking for snprintf... yes
checking for dbm_open... no
checking for dbm_open in -lndbm... no
checking for __db_ndbm_open in -ldb... no
checking for dbm_open in -lgdbm... no
checking for dbm_open in -lgdbm_compat... yes
checking gdbm/ndbm.h usability... yes
checking gdbm/ndbm.h presence... yes
checking for gdbm/ndbm.h... yes
checking for pkg-config... /nix/store/1ccr6a50qadpgr1aa2c3a1rpylkzhzab-pkg-config-0.29.2/bin/pkg-config
checking for glib-2.0 >= 2.0.0... yes
checking GLIB2_CFLAGS... -I/nix/store/kbh1dk6k8chjh853w5d6sadlkdh94j74-glib-2.54.1-dev/include/glib-2.0 -I/nix/store/02nssrw1njxnqpfkib9jyr5s08w6nvkc-glib-2.54.1/lib/glib-2.0/include
checking GLIB2_LIBS... -L/nix/store/02nssrw1njxnqpfkib9jyr5s08w6nvkc-glib-2.54.1/lib -lglib-2.0
checking fcntl.h usability... yes
checking fcntl.h presence... yes
checking for fcntl.h... yes
checking glib.h usability... no
checking glib.h presence... no
checking for glib.h... no
checking malloc.h usability... yes
checking malloc.h presence... yes
checking for malloc.h... yes
checking for an ANSI C-conforming const... yes
checking for stdlib.h... (cached) yes
checking for GNU libc compatible malloc... yes
checking return type of signal handlers... void
configure: creating ./config.status
config.status: creating Makefile
config.status: creating config.h
config.status: executing depfiles commands
config.status: executing libtool commands
building
build flags: SHELL=/nix/store/h404wfcz8rzzlq8vr4z7plcijwzfci72-bash-4.4-p12/bin/bash
gcc -I. -I. -I. -g -O2 -o skkdic-expr ./skkdic-expr.c -lgdbm_compat   -lgdbm
gcc -I. -I. -I. -g -O2 -o skkdic-sort ./skkdic-sort.c
gcc -I. -I. -I. -g -O2 -o skkdic-count ./skkdic-count.c
gcc -I. -I. -I. -g -O2 -I/nix/store/kbh1dk6k8chjh853w5d6sadlkdh94j74-glib-2.54.1-dev/include/glib-2.0 -I/nix/store/02nssrw1njxnqpfkib9jyr5s08w6nvkc-glib-2.54.1/lib/glib-2.0/include -o skkdic-expr2 ./skkdic-expr2.c -L/nix/store/02nssrw1njxnqpfkib9jyr5s08w6nvkc-glib-2.54.1/lib -lglib-2.0
glibPreInstallPhase
installing
install flags: install SHELL=/nix/store/h404wfcz8rzzlq8vr4z7plcijwzfci72-bash-4.4-p12/bin/bash gsettingsschemadir=/nix/store/jw6i49gcrx2bqsgmn14zc2s4ipqg0rav-skktools/share/gsettings-schemas/skktools/glib-2.0/schemas/
./mkinstalldirs /nix/store/jw6i49gcrx2bqsgmn14zc2s4ipqg0rav-skktools/bin
mkdir /nix/store/jw6i49gcrx2bqsgmn14zc2s4ipqg0rav-skktools/bin
 /nix/store/8qh2yq93x7ijvkvrf9gi0jhxr8jwh341-coreutils-8.28/bin/install -c skkdic-expr /nix/store/jw6i49gcrx2bqsgmn14zc2s4ipqg0rav-skktools/bin/
 /nix/store/8qh2yq93x7ijvkvrf9gi0jhxr8jwh341-coreutils-8.28/bin/install -c skkdic-sort /nix/store/jw6i49gcrx2bqsgmn14zc2s4ipqg0rav-skktools/bin/
 /nix/store/8qh2yq93x7ijvkvrf9gi0jhxr8jwh341-coreutils-8.28/bin/install -c skkdic-count /nix/store/jw6i49gcrx2bqsgmn14zc2s4ipqg0rav-skktools/bin/
 /nix/store/8qh2yq93x7ijvkvrf9gi0jhxr8jwh341-coreutils-8.28/bin/install -c skkdic-expr2 /nix/store/jw6i49gcrx2bqsgmn14zc2s4ipqg0rav-skktools/bin/
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jw6i49gcrx2bqsgmn14zc2s4ipqg0rav-skktools
shrinking /nix/store/jw6i49gcrx2bqsgmn14zc2s4ipqg0rav-skktools/bin/skkdic-count
shrinking /nix/store/jw6i49gcrx2bqsgmn14zc2s4ipqg0rav-skktools/bin/skkdic-expr
shrinking /nix/store/jw6i49gcrx2bqsgmn14zc2s4ipqg0rav-skktools/bin/skkdic-expr2
shrinking /nix/store/jw6i49gcrx2bqsgmn14zc2s4ipqg0rav-skktools/bin/skkdic-sort
stripping (with flags -S) in /nix/store/jw6i49gcrx2bqsgmn14zc2s4ipqg0rav-skktools/bin
patching script interpreter paths in /nix/store/jw6i49gcrx2bqsgmn14zc2s4ipqg0rav-skktools
checking for references to /tmp/nix-build-skktools.drv-0 in /nix/store/jw6i49gcrx2bqsgmn14zc2s4ipqg0rav-skktools...
/nix/store/jw6i49gcrx2bqsgmn14zc2s4ipqg0rav-skktools

@yuriaisaka
Copy link
Contributor Author

I've just noticed that the derivation in skktools/default.nix has a name nonconforming to the standard convention:

  name = "skktools";

I've pushed a fix to pr-skktools-init and my apologies for any inconvenience it may have caused.

GrahamcOfBorg
GrahamcOfBorg reviewed Oct 25, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vf6rj90452m2myjyvlrf9kv3ha5qd9hw-skktools-1.3.3
shrinking /nix/store/vf6rj90452m2myjyvlrf9kv3ha5qd9hw-skktools-1.3.3/bin/skkdic-count
shrinking /nix/store/vf6rj90452m2myjyvlrf9kv3ha5qd9hw-skktools-1.3.3/bin/skkdic-expr
shrinking /nix/store/vf6rj90452m2myjyvlrf9kv3ha5qd9hw-skktools-1.3.3/bin/skkdic-expr2
shrinking /nix/store/vf6rj90452m2myjyvlrf9kv3ha5qd9hw-skktools-1.3.3/bin/skkdic-sort
stripping (with flags -S) in /nix/store/vf6rj90452m2myjyvlrf9kv3ha5qd9hw-skktools-1.3.3/bin
patching script interpreter paths in /nix/store/vf6rj90452m2myjyvlrf9kv3ha5qd9hw-skktools-1.3.3
checking for references to /tmp/nix-build-skktools-1.3.3.drv-0 in /nix/store/vf6rj90452m2myjyvlrf9kv3ha5qd9hw-skktools-1.3.3...
/nix/store/vf6rj90452m2myjyvlrf9kv3ha5qd9hw-skktools-1.3.3

@joachifm joachifm merged commit ad1bf41 into NixOS:master Oct 28, 2017
@yuriaisaka yuriaisaka deleted the pr-skktools-init branch November 20, 2017 23:05
@c0bw3b c0bw3b mentioned this pull request Nov 25, 2017
Merged
8 tasks
@yuriaisaka yuriaisaka mentioned this pull request Nov 29, 2017
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamcOfBorg GrahamcOfBorg GrahamcOfBorg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yuriaisaka @grahamc @GrahamcOfBorg @joachifm