Dump malformed ingress packets at DEBUG log level.

whitequark · whitequark · commit a3a6565abe07 · 2017-10-24T20:19:56.000Z
diff --git a/src/iface/ethernet.rs b/src/iface/ethernet.rs
@@ -175,6 +175,7 @@ impl<'a, 'b, 'c, DeviceT: Device + 'a> Interface<'a, 'b, 'c, DeviceT> {
                     Ok(response) => response,
                     Err(err) => {
                         net_debug!("cannot process ingress packet: {}", err);
+                        net_debug!("packet dump follows:\n{}");
                         return Err(err)
                     }
                 };
@@ -274,7 +275,7 @@ impl<'a, 'b, 'c, DeviceT: Device + 'a> Interface<'a, 'b, 'c, DeviceT> {
                                         &source_hardware_addr);
                 } else {
                     // Discard packets with non-unicast source addresses.
-                    net_debug!("non-unicast source in {}", arp_repr);
+                    net_debug!("non-unicast source address");
                     return Err(Error::Malformed)
                 }
 
@@ -305,7 +306,7 @@ impl<'a, 'b, 'c, DeviceT: Device + 'a> Interface<'a, 'b, 'c, DeviceT> {
 
         if !ipv4_repr.src_addr.is_unicast() {
             // Discard packets with non-unicast source addresses.
-            net_debug!("non-unicast source in {}", ipv4_repr);
+            net_debug!("non-unicast source address");
             return Err(Error::Malformed)
         }
 
