Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser: correctly parse local variable in implicit block exception handler #5178

Merged
merged 1 commit into from
Oct 25, 2017
Merged

Parser: correctly parse local variable in implicit block exception handler #5178

merged 1 commit into from
Oct 25, 2017
+3 −2

Conversation

makenowjust
Copy link
Contributor

Fixed #5177

@straight-shoota
Copy link
Member

I guess this only fixes the first example of #5177? Otherwise there should probably be a spec for the second one.

@makenowjust
Copy link
Contributor Author

@straight-shoota all examples in #5177 are fixed, no problem.

@RX14 RX14 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler labels Oct 24, 2017
asterite
asterite approved these changes Oct 25, 2017
View reviewed changes
Copy link
Member

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いつもありがとう！

@asterite asterite merged commit 017f9c9 into crystal-lang:master Oct 25, 2017
@makenowjust makenowjust deleted the fix/crystal/5177-local-variable-in-implicit-block-exception-handler branch October 25, 2017 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysbaddaden ysbaddaden

@asterite asterite

@RX14 RX14

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@makenowjust @straight-shoota @ysbaddaden @asterite @RX14