Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "vc: Broken on i686" #30779

Merged
merged 1 commit into from Oct 25, 2017
Merged

Revert "vc: Broken on i686" #30779

merged 1 commit into from Oct 25, 2017

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Oct 24, 2017

Motivation for this change

Not broken

This reverts commit c58c1f3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@veprbl
Revert "vc: Broken on i686"
8b56d8e 
Not broken

This reverts commit c58c1f3.
@Mic92 Mic92 merged commit 550c6bf into NixOS:master Oct 25, 2017
@veprbl veprbl deleted the vc_not_broken branch December 1, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@veprbl @Mic92