Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plymouth service: fix symlink to defaults #30774

Merged
merged 1 commit into from Oct 25, 2017

Conversation

plutotulp
Copy link
Contributor

@plutotulp plutotulp commented Oct 24, 2017

Symlink for plymouthd.defaults was pointing to nonexisting target, seemingly
because of a spelling error. I don't know that fixing the symlink actually makes a difference for the service, but /etc/plymouth certainly looks tidier :)

Be gentle, this is my first PR ever.

Motivation for this change

I just had a look around in /etc/plymouth and noticed that plymouthd.defaults was a dangling symlink.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Symlink for plymouthd.defaults was pointing to nonexisting target
because of a spelling error.
@fpletz
Copy link
Member

fpletz commented Oct 25, 2017

Cool, nice catch! Thanks for the patch and for reading our contribution guidelines. Looks fine. 👍

@fpletz fpletz merged commit f561dab into NixOS:master Oct 25, 2017
@plutotulp plutotulp deleted the plymouth-defaults branch October 25, 2017 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants