convox: init at 20171002150509 #30377
Conversation
| description = "Open-source PaaS"; | ||
| license = lib.licenses.asl20; | ||
| platforms = lib.platforms.linux ++ lib.platforms.darwin; | ||
| }; |
There was a problem hiding this comment.
What’s the right way to set that? Should I add myself as a maintainer?
There was a problem hiding this comment.
Yep, just add yourself to lib/maintainers.nix, and then add a maintainers = with lib.maintainers; [ shosti ]; entry to meta.
| goPackagePath = "github.com/convox/rack"; | ||
| subPackages = [ "cmd/convox" ]; | ||
|
|
||
| src = fetchurl { |
There was a problem hiding this comment.
You can use fetchFromGitHub instead, so import fetchFromGitHub instead of fetchurl at the top, and:
{
src = fetchFromGitHub {
owner = "convox";
repo = "rack";
rev = version;
sha256 = "05hxrb36b9fxgid3n43z43k4zw11akn80kggcxkxx4ba3z6pff8q";
};
}
| @@ -0,0 +1,21 @@ | |||
| { lib, fetchurl, buildGoPackage }: | |||
There was a problem hiding this comment.
I think it's more common or idiomatic to put stdenv instead of lib directly. Your meta then becomes:
{
meta = with stdenv.lib; {
description = "Open-source PaaS";
homepage = https://convox.com;
license = licenses.asl20;
maintainers = with maintainers; [ shosti ];
platforms = with platforms; linux ++ darwin;
};
}
|
@vyp updated. |
|
The build seems to be failing on OSX with |
|
@shosti if you're unable to test on osx, you can simply remove it from the list of supported platforms. |
Motivation for this change
This adds the CLI tool for convox, which is a PaaS built on top of AWS.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)