Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weechat-xmpp: init at 2017-08-30 #30367

Merged
merged 1 commit into from Oct 25, 2017
Merged

weechat-xmpp: init at 2017-08-30 #30367

merged 1 commit into from Oct 25, 2017

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Oct 12, 2017 •
edited

Motivation for this change

weechat-jabber requires xmpppy and as I don't like to install such libraries globally I decided that it's worth creating a simple derivation for this.

Note: I'm afraid this might generate legal issues as the source isn't distributed with a license on GitHub. Can anyone give me some advice how to proceed here?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Oct 13, 2017 •
edited

It's gpl3: https://github.com/sleduc/weechat-xmpp/blob/master/jabber.py#L7

@vyp
Copy link
Member

vyp commented Oct 13, 2017

Can anyone give me some advice how to proceed here?

To answer your question for reference, I think it's reasonable to set it to stdenv.lib.licenses.unfree. (I made a PR to put this instruction in CONTRIBUTING.md: #29668.)

I'm no lawyer, but it seems safer to assume by default we have no rights if they haven't been explicitly given to us. However, in such a case, I'm not sure if we'd be able to build from source (i.e. use fetchFromGitHub and friends), because I think that would mean we distribute their software via hydra/binary cache, which we don't have the right to do if we assume we have no rights. So upstream would have to supply us with pre-built binaries or something for us to download (unless their license is nonfree but redistributable, but in that case a license has been given to us so it isn't relevant to the question).

A lot of the times though, if upstream has made the source code publicly available, then they usually are okay with people using/redistributing etc. their software, they probably just forgot to 'formally' declare it. So it might be worth asking upstream somehow if that is indeed the case or not, and to add some free software license to their source code if it is.

vyp
vyp suggested changes Oct 13, 2017
View reviewed changes
pkgs/applications/networking/instant-messengers/weechat-xmpp/default.nix Outdated
description = "A fork of the jabber plugin for weechat";
homepage = "https://github.com/sleduc/weechat-xmpp";
maintainers = with maintainers; [ ma27 ];
license = licenses.gpl3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpl3Plus

@joachifm joachifm merged commit f13c421 into NixOS:master Oct 25, 2017
@Ma27 Ma27 deleted the init-weechat-xmpp branch October 25, 2017 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyp vyp vyp requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ma27 @Mic92 @vyp @joachifm