djbdns: fix root server list at build time #30379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerith666
referenced
this pull request
Oct 13, 2017
with improvements suggested by Jörg Thalheim <joerg@thalheim.io>
|
I also added 6ec6af4 |
Mic92
reviewed
Oct 13, 2017
| # so we have to ensure servers/@ exists ourselves.) | ||
| if [ ! -e $out/servers/@ ]; then | ||
| #note: symlink does not work, not sure why | ||
| cp ${pkgs.djbdns}/etc/dnsroots.global $out/servers/@; |
There was a problem hiding this comment.
Symlink would not work because of chroot. I added this comment to commit I pushed on master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as suggested by @peterhoeg in
1b7e5ea#commitcomment-24560631
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)