Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services.compton: add opacityRules option #30364

Merged
merged 1 commit into from Oct 13, 2017

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Oct 12, 2017

Motivation for this change

A true hacker requires a transparent terminal ;)

Furthermore I'd love to have this configurable using the services.compton module.

To test the change I built the following test VM:

{
  compton = { pkgs, ... }: {
    users.extraUsers.vm = {
      isNormalUser = true;
      password = "vm";
    };
    environment.systemPackages = [ pkgs.google-chrome ];
    services.xserver = {
      enable = true;
      windowManager.i3.enable = true;
      windowManager.default = "i3";
    };
    services.compton = {
      enable = true;
      opacityRules = [ "70:class_g = 'Google-chrome'" ];
    };
    nixpkgs.config.allowUnfree = true;
  };
}

This makes google-chrome transparent in the VM.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@fpletz fpletz merged commit c621819 into NixOS:master Oct 13, 2017
@Ma27 Ma27 deleted the compton/opacity-rules-support branch October 13, 2017 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants