profanity: enable python and gpg support, parallel builds and enforcement of enabled features #30366
Conversation
|
cc @devhell |
| ++ optionals traySupport [ gnome2.gtk ]; | ||
| ++ optionals traySupport [ gnome2.gtk ] | ||
| ++ optionals gpgSupport [ gpgme ] | ||
| ++ optionals pythonSupport [ python ]; |
There was a problem hiding this comment.
What python version is preferred here? Archlinux builds against python3.
There was a problem hiding this comment.
This is set at https://github.com/Moredread/nixpkgs/blob/ebd3a4622453665df5d600ab4a69c9d23060b88c/pkgs/top-level/all-packages.nix#L16067-L16068 which is python 2. I intended to use python 3, I'll change it.
Does that mean Python bindings? In that case, can you add the package also to |
Moredread
force-pushed
the
profanity-options
branch
2 times, most recently
from
76ae104
to
024fb42
Compare
|
@FRidh I think it's only for plugin support, i.e. interacting from python is not possible as far as I can see. I renamed the option so it is more clear. |
|
Mhh, it seems that it doesn't compile with the tray icon feature flag (so the last commit actually catches the problem, until now it just wasn't compiled in). Can someone on MacOS have a look whether tray support works on that platform or needs to be disabled? |
Moredread
force-pushed
the
profanity-options
branch
from
024fb42
to
9f850b0
Compare
|
I renamed the gpgSupport option to pgpOption to match the usage in the package |
pkgs/top-level/all-packages.nix
Outdated
| autoAwaySupport = config.profanity.autoAwaySupport or true; | ||
| pgpSupport = config.profanity.pgpSupport or true; | ||
| pythonPluginSupport = config.profanity.pythonPluginSupport or true; | ||
| python = config.profanity.pythonPackage or python3; | ||
| }; |
There was a problem hiding this comment.
Can you get rid of these config options. If one wants to change an option one can just override the expression.
There was a problem hiding this comment.
All of them, or only those I've added?
When the feature flags during configuration are not set explicitly the build will continue even when needed libs are missing, disabling the feature. To get notified of problems, we set the feature flags explicitly.
Moredread
force-pushed
the
profanity-options
branch
from
9f850b0
to
e4cf663
Compare
Motivation for this change
Enabling python and gpg support, parallel builds and enforcement of enabled features.
If wanted, I can split up the PR or squash commits as needed.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)