Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qutebrowser: 0.11 -> 1.0 #30365

Merged
merged 2 commits into from Oct 13, 2017
Merged

qutebrowser: 0.11 -> 1.0 #30365

merged 2 commits into from Oct 13, 2017

Conversation

timokau
Copy link
Member

@timokau timokau commented Oct 12, 2017 •
edited

This updates has a few breaking changes, most importantly WebEngine
is now enabled by default and the configuration system was completely
changed (requiring uers to manually migrate their configuration).

More info: https://blog.qutebrowser.org/qutebrowser-v100-released.html

withWebEngineDefault is a bit unfortunately named now. The alternative would be to replace it by withWebKitDefault, but I'm not sure if breaking the config of people that set that variable would be worth it.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@timokau
qutebrowser: 0.11 -> 1.0
5db87f3 
This updates has a few breaking changes, most importantly WebEngine
is now enabled by default and the configuration system was completely
changed (requiring uers to manually migrate their configuration).

More info: https://blog.qutebrowser.org/qutebrowser-v100-released.html
@neeasade
Copy link
Member

is the failed check just from taking to long to build qt on travis?

@timokau
Copy link
Member Author

timokau commented Oct 13, 2017

Probably
I tested it with nixpkgs-17.09 so I wouldn't have to recompile qt, and at least there it works.

@neeasade
Copy link
Member

good good

FYI https://github.com/qutebrowser/qutebrowser/releases/tag/v1.0.1

@timokau
Copy link
Member Author

timokau commented Oct 13, 2017 •
edited

I updated to 1.0.1 (I hope its allright to do two updates in one pr)

@Mic92 Mic92 merged commit 06fc476 into NixOS:master Oct 13, 2017
@Mic92
Copy link
Member

Mic92 commented Oct 13, 2017

Thanks!

erictapen pushed a commit to erictapen/nixpkgs that referenced this pull request Oct 13, 2017
@timokau @erictapen
qutebrowser: 0.11 -> 1.0.1 (NixOS#30365)
f46e327 
* qutebrowser: 0.11 -> 1.0

This updates has a few breaking changes, most importantly WebEngine
is now enabled by default and the configuration system was completely
changed (requiring uers to manually migrate their configuration).

More info: https://blog.qutebrowser.org/qutebrowser-v100-released.html

* qutebrowser: 1.0.0 -> 1.0.1
@timokau timokau deleted the qutebrowser-1.0 branch October 14, 2017 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timokau @neeasade @Mic92