callCabal2nix: Don't rebuild unchanged cabal file (Fixed #23880) #30751
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#23880 caused #24245 and was reverted. This PR fixes the issue by only applying
filterSource
on sources of typepath
. I'm usually weary of these dynamically typed things, but I think it's worth it in this case. Editing haskell files should not result in the cabal file being reevaluated bycabal2nix
, and it definitely shouldn't cause the entire source tree to be copied into the nix store.Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)