Formatter: correctly indent implicit exception handler of do/end block #5176

makenowjust · 2017-10-24T14:47:27Z

Now, crystal tool format keeps this code.

loop do
  loop do
    1
  rescue
    2
  end
end

Thanks for reporting, @straight-shoota!

Fixed crystal-lang#5175

RX14 · 2017-10-24T21:21:12Z

src/compiler/crystal/tools/formatter.cr

@@ -62,7 +62,7 @@ module Crystal
    @inside_lib : Int32
    @inside_struct_or_union : Int32
    @dot_column : Int32?
-    @def_indent : Int32
+    @implicit_exception_handler_indent : Int32


Would just exception_handler_indent be an equally good name?

Yes, @implicit_exception_handler_indent looks too long to me, but implicit is important as same as that.

Formatter: correctly indent implicit exception handler of do/end block

f8af24e

Fixed crystal-lang#5175

RX14 approved these changes Oct 24, 2017

View reviewed changes

RX14 reviewed Oct 24, 2017

View reviewed changes

RX14 approved these changes Oct 25, 2017

View reviewed changes

ysbaddaden approved these changes Oct 25, 2017

View reviewed changes

asterite approved these changes Oct 25, 2017

View reviewed changes

asterite merged commit 2d2ebac into crystal-lang:master Oct 25, 2017

makenowjust deleted the fix/crystal-format/indent-implicit-exception-handler-with-do-end branch October 25, 2017 14:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Formatter: correctly indent implicit exception handler of do/end block #5176

Formatter: correctly indent implicit exception handler of do/end block #5176

makenowjust commented Oct 24, 2017

RX14 Oct 24, 2017

makenowjust Oct 25, 2017

Formatter: correctly indent implicit exception handler of do/end block #5176

Formatter: correctly indent implicit exception handler of do/end block #5176

Conversation

makenowjust commented Oct 24, 2017

RX14 Oct 24, 2017

Choose a reason for hiding this comment

makenowjust Oct 25, 2017

Choose a reason for hiding this comment