Update jupyter and enable a few tests #30762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Oct 25, 2017
| }; | ||
|
|
||
| LC_ALL = "en_US.UTF-8"; | ||
| LC_ALL = "en_US.utf8"; |
There was a problem hiding this comment.
Is en_US.utf8 a valid identifier?
There was a problem hiding this comment.
$ locale -a
C
en_GB.utf8
en_US.utf8
POSIX
There was a problem hiding this comment.
Interesting on ubuntu/archlinux always the first notation is used in /etc/locale.gen. Python seems to accept both variants:
$ LC_ALL=en_US.utf8 python -c 'import locale; print(locale.getdefaultlocale())'
('en_US', 'UTF-8')
$ LC_ALL=en_US.UTF-8 python -c 'import locale; print(locale.getdefaultlocale())'
('en_US', 'UTF-8')
|
Thanks! |
|
@Fuuzetsu I also just ran into build failures for Jupyter on OS X. I suspect it's caused by this PR. Is there a dedicated issue for that? Is it worth opening one? |
|
I haven't opened one. I have set doCheck to false in own checkout at the time to get around that. We should create an issue and/or just disable to test on OSX in the expression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @FRidh
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)