Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pptp: correct reference to ${iproute}/bin/ip #30759

Merged
merged 1 commit into from Oct 28, 2017
Merged

pptp: correct reference to ${iproute}/bin/ip #30759

merged 1 commit into from Oct 28, 2017

Conversation

FlorentBecker
Copy link
Contributor

@FlorentBecker FlorentBecker commented Oct 24, 2017 •
edited

Motivation for this change

A reference to /bin/ip was left hanging, causing failure when establishing a connection caused
pptp to try and manipulate routes.

Things done
  • Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-
    nix.useSandbox) on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested establishing a pptp connection.
  • Fits CONTRIBUTING.md.

@FlorentBecker
pptp: correct reference to ${iproute}/bin/ip
30c739f 
A reference to /bin/ip was left hanging, causing failure when establishing a connection caused
pptp to try and manipulate roots.
@joachifm joachifm merged commit 1f966e9 into NixOS:master Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FlorentBecker @joachifm