Add Travis to test builds on macOS + Linux #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allejo
force-pushed
the
feature/travis-tests
branch
from
761e2cb
to
9251fe3
Compare
macsforme
reviewed
Oct 17, 2017
There was a problem hiding this comment.
I'm not that familiar with Travis CI, but this looks fine to me. From what I can tell, debug builds fail in linux due to an older GCC version (do we need to pick a different distribution than trusty?), and they fail on macOS because clang throws a lot of warnings that we haven't addressed yet.
|
For Linux, only Trusty and Precise are available so that's what we're stuck with |
allejo
force-pushed
the
feature/travis-tests
branch
from
b9b8130
to
5c6aae6
Compare
|
Closing this. By the time we start working on 2.6, Travis OS options will have changed and so will have our build deps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding earlier discussions, adding simple Travis tests to make sure things continue to build after commits on both Linux and macOS.
As an example: https://travis-ci.org/allejo/bzflag/builds/285422595
Currently, can't run
./configurewith the--enable-debugflag since it'll treat warnings as errors; this affects both Linux and macOS, see here:Additionally, should we add IRC notifications? If so, how's BZnotify configured/what endpoint should we point to?