Firefox: do not crash on print dialog. #30242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ping @nbp |
|
Is this still reproducible? |
|
The |
|
@joachifm I updated to only include the space change in optionals. This PR now boils down to a minor nitpick because no one ever had an issue with this, so I guess no one ever disables ffmpegSpport. |
|
@jtojnar Can you show me the commit that propagates GTK dialogues ? |
|
GStreamer is actually no longer supported by Firefox and will be removed in #39985 |
|
@jtojnar Ah, I completely forgot about that one. Thanks for solving and closing :-D. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox sometimes crashes when requested to print a page.
The issue is that related gsettings are not found.
I know this should be handled by the gnome3 desktop-manager environment, but for some reason it is not.
Considering how fragile that method is, and that all the similar packages are already wrapped,
I think we should also wrap firefox.
It's a pretty trivial change as it only affects the wrapper.
/cc @vcunat for this ehances 700d618