Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

newsbeuter: fix CVE-2017-12904 #30227

Merged
merged 1 commit into from Oct 11, 2017
Merged

newsbeuter: fix CVE-2017-12904 #30227

merged 1 commit into from Oct 11, 2017

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Oct 8, 2017

Motivation for this change

Improper Neutralization of Special Elements used in an OS Command in bookmarking function of Newsbeuter versions 0.7 through 2.9 allows remote attackers to perform user-assisted code execution by crafting an RSS item that includes shell code in its title and/or URL.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@joachifm
Copy link
Contributor

On a somewhat related note, seems like https://github.com/newsboat/newsboat is the maintained version these days, per akrennmair/newsbeuter@7c981f4

@joachifm
Copy link
Contributor

Also, upstream provides a patch at https://github.com/akrennmair/newsbeuter/commit/d1460189f6f810ca9a3687af7bc43feb7f2af2d9.patch, perhaps use that instead of AUR.

@joachifm joachifm merged commit c405302 into NixOS:master Oct 11, 2017
@pbogdan pbogdan deleted the newsbeuter-cve-2017-12904 branch December 3, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pbogdan @joachifm