Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgnurl: Use recommended configure flags. #30233

Merged
merged 1 commit into from Oct 10, 2017

Conversation

falsifian
Copy link
Contributor

See #30219 (comment)

Motivation for this change

Recommended by upstream maintainer: #30219 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@falsifian
Copy link
Contributor Author

Before merging this, someone may want to verify gnunet still works properly with it. There's no reason to expect it wouldn't, as these changes are recommended by the upstream maintainer.

@falsifian falsifian merged commit d9a0376 into NixOS:master Oct 10, 2017
@falsifian falsifian deleted the libgnurl_configure branch October 10, 2017 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant