Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coq: 8.7+beta1 -> 8.7+beta2 #30247

Merged
merged 1 commit into from Oct 11, 2017
Merged

coq: 8.7+beta1 -> 8.7+beta2 #30247

merged 1 commit into from Oct 11, 2017

Conversation

maximedenes
Copy link
Contributor

@maximedenes maximedenes commented Oct 9, 2017 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • [ X ] Fits CONTRIBUTING.md.

Zimmi48
Zimmi48 approved these changes Oct 9, 2017
View reviewed changes
Copy link
Member

@Zimmi48 Zimmi48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properly speaking, the commit message should be coq_8_7: 8.7+beta1 -> 8.7+beta2, given how the coq attribute itself still refers to Coq 8.6.1.

@vbgl
Copy link
Contributor

vbgl commented Oct 9, 2017

Thanks for your PR and welcome to nixpkgs. Would you like to add yourself as a maintainer of the coq package?

Concerning the commit message, CONTRIBUTING.md talks about the package “name” rather than its attribute path. As it stands, it looks good to me. It probably does not matter much…

@vbgl vbgl merged commit d1e1ee7 into NixOS:master Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zimmi48 Zimmi48 Zimmi48 approved these changes

Assignees
No one assigned
Labels
12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maximedenes @vbgl @Zimmi48 @Janik-Haag