Added `pkcs5_pbkdf2_hmac` to `lib_crypto.cr` and `pkcs5.cr` #5021

aurimasniekis · 2017-09-22T15:18:56Z

Added pkcs5_pbkdf2_hmac function to support pbkdf2 with multiple algorithm

aurimasniekis · 2017-09-22T15:25:27Z

libcrypto was not found if I understood correctly the CircleCI error...

sdogruyol · 2017-09-22T16:17:13Z

Hey @aurimasniekis, welcome and congrats for your first contribution to Crystal 🎉

aurimasniekis · 2017-09-22T16:24:04Z

Hi, @sdogruyol thanks your welcoming! I can't figure out why build doesn't want to work. I tried the same solution which helped to build on my local machine but it doesn't work. The most interesting thing that original PKCS5_PBKDF2_HMAC_SHA1 is found but additional PKCS5_PBKDF2_HMAC method is not found then it's in the same lib. Even then in OpenSSL PKCS5_PBKDF2_HMAC_SHA1 wraps a call PKCS5_PBKDF2_HMAC source

Sija · 2017-09-22T16:29:46Z

@aurimasniekis See samr7/vanitygen#45.

aurimasniekis · 2017-09-22T16:31:54Z

@Sija thanks for the suggestion, I will try it out. But why then previous PKCS5_PBKDF2_HMAC_SHA1 works? :D

Sija · 2017-09-22T16:34:35Z

@aurimasniekis I guess because it has been changed between OpenSSL versions 0.9 and 1.0, see source for 0.9.8 to see what I mean.

Sija · 2017-09-22T16:44:16Z

@aurimasniekis FYI, PKCS5_PBKDF2_HMAC was added in openssl/openssl@856640b. Header declaration though was added later in openssl/openssl@777c47a.

aurimasniekis · 2017-09-22T17:19:13Z

I modified Makefile to accept custom ENV variable CRYSTAL_FLAGS to pass it to the crystal build so that I can pass in bin/ci flag --link-flags -L/usr/local/opt/openssl/lib and then everything works.

Sija · 2017-09-24T00:59:47Z

Makefile

@@ -27,7 +27,7 @@ static ?=       ## Enable static linking
 O := .build
 SOURCES := $(shell find src -name '*.cr')
 SPEC_SOURCES := $(shell find spec -name '*.cr')
-FLAGS := $(if $(release),--release )$(if $(stats),--stats )$(if $(progress),--progress )$(if $(threads),--threads $(threads) )$(if $(debug),-d )$(if $(static),--static )
+FLAGS := $(if $(release),--release )$(if $(stats),--stats )$(if $(progress),--progress )$(if $(threads),--threads $(threads) )$(if $(debug),-d )$(if $(static),--static )$(if $(CRYSTAL_FLAGS),$(CRYSTAL_FLAGS) )


Splitting $(CRYSTAL_FLAGS) changes into a separate line for sake of clarity might be a good thing here, WDYT @aurimasniekis?

If you think it's better than yes I could do it. But personally, I do not think many people go into Makefile

I think so, yes. ATM it's the longest line in the whole file and this change would make it even longer, not nice.

Sija · 2017-09-24T01:01:01Z

spec/std/openssl/pkcs5_spec.cr

+      {2**16, 16, "1b345dd55f62a35aecdb9229bc7ae95b"},
+      {2**16, 32, "1b345dd55f62a35aecdb9229bc7ae95b305a8d538940134627e46f82d3a41e5e"},
+    ].each do |(iterations, key_size, expected)|
+      OpenSSL::PKCS5.pbkdf2_hmac(:sha1, "password", "salt", iterations, key_size).hexstring.should eq expected


Could you add samples for other algos as well?

Yes, I should do it... I was bit lazy...

bew · 2017-09-24T11:00:14Z

spec/std/openssl/pkcs5_spec.cr

@@ -12,4 +12,15 @@ describe OpenSSL::PKCS5 do
      OpenSSL::PKCS5.pbkdf2_hmac_sha1("password", "salt", iterations, key_size).hexstring.should eq expected
    end
  end
+
+  it "computes pbkdf2_hmac" do
+    [


You could use a tuple here instead of an array

I will try because I just copied from original test case

Sija · 2017-10-04T22:18:39Z

@aurimasniekis 🏓

ysbaddaden · 2017-10-05T08:21:59Z

We don't have a strong policy about supported OpenSSL versions in Crystal, but v0.9.8 is still used and deployed a lot.

If an OpenSSL feature is only available on "recent" OpenSSL release, there should be an OpenSSL version check to enable the feature, just like we do for other OpenSSL features that are only available in v1.0 or v1.1.

aurimasniekis · 2017-10-06T10:44:45Z

@Sija sorry, I forgot about this PR after holidays
@ysbaddaden Do you by wrapping with version check would be sufficient?

aurimasniekis · 2017-10-06T11:25:00Z

Could someone explain the CircleCI error

Error: formatting 'spec/std/openssl/pkcs5_spec.cr' produced changes

Sija · 2017-10-06T11:32:47Z

@aurimasniekis it's a check done by crystal tool format --check. always run crystal tool format before pushing to avoid failing CI because of it.

aurimasniekis · 2017-10-06T11:36:38Z

@Sija thanks, fixed

Willamin · 2018-04-02T19:59:37Z

Is there any more movement on this PR?

kingsleyh · 2018-06-03T17:56:27Z

Hi - I really need this - I've taken the code and patched my library to get it to work - but it would be really awesome if would be integrated into Crystal so I could avoid the patching

straight-shoota · 2021-01-23T15:07:08Z

Resolved by #6975

aurimasniekis force-pushed the feature/opensll_pbkdf2_implementation branch from a141b97 to dc525e2 Compare September 22, 2017 15:54

aurimasniekis force-pushed the feature/opensll_pbkdf2_implementation branch from a377535 to b2a2921 Compare September 22, 2017 16:22

aurimasniekis force-pushed the feature/opensll_pbkdf2_implementation branch from 1cb97a4 to 30348ef Compare September 22, 2017 16:43

aurimasniekis force-pushed the feature/opensll_pbkdf2_implementation branch 2 times, most recently from 37f58c5 to cf7835c Compare September 22, 2017 17:13

Sija reviewed Sep 24, 2017

View reviewed changes

bew reviewed Sep 24, 2017

View reviewed changes

aurimasniekis force-pushed the feature/opensll_pbkdf2_implementation branch from cf7835c to 8b6a2c4 Compare October 6, 2017 11:06

Added pkcs5_pbkdf2_hmac to lib_crypto.cr and pkcs5.cr

7438838

aurimasniekis force-pushed the feature/opensll_pbkdf2_implementation branch from 8b6a2c4 to 7438838 Compare October 6, 2017 11:35

This was referenced Oct 21, 2018

Expose LibCrypt PKCS5_PBKDF2_HMAC #6973

Closed

Expose LibCrypt's PKCS5_PBKDF2_HMAC #6975

Merged

straight-shoota closed this Jan 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added `pkcs5_pbkdf2_hmac` to `lib_crypto.cr` and `pkcs5.cr` #5021

Added `pkcs5_pbkdf2_hmac` to `lib_crypto.cr` and `pkcs5.cr` #5021

aurimasniekis commented Sep 22, 2017

aurimasniekis commented Sep 22, 2017

sdogruyol commented Sep 22, 2017

aurimasniekis commented Sep 22, 2017 •

edited

Loading

Sija commented Sep 22, 2017

aurimasniekis commented Sep 22, 2017

Sija commented Sep 22, 2017

Sija commented Sep 22, 2017 •

edited

Loading

aurimasniekis commented Sep 22, 2017

Sija Sep 24, 2017

aurimasniekis Sep 24, 2017

Sija Sep 24, 2017 •

edited

Loading

Sija Sep 24, 2017

aurimasniekis Sep 24, 2017

bew Sep 24, 2017

aurimasniekis Oct 6, 2017

Sija commented Oct 4, 2017

ysbaddaden commented Oct 5, 2017

aurimasniekis commented Oct 6, 2017

aurimasniekis commented Oct 6, 2017

Sija commented Oct 6, 2017

aurimasniekis commented Oct 6, 2017

Willamin commented Apr 2, 2018

kingsleyh commented Jun 3, 2018

straight-shoota commented Jan 23, 2021

Added pkcs5_pbkdf2_hmac to lib_crypto.cr and pkcs5.cr #5021

Added pkcs5_pbkdf2_hmac to lib_crypto.cr and pkcs5.cr #5021

Conversation

aurimasniekis commented Sep 22, 2017

aurimasniekis commented Sep 22, 2017

sdogruyol commented Sep 22, 2017

aurimasniekis commented Sep 22, 2017 • edited Loading

Sija commented Sep 22, 2017

aurimasniekis commented Sep 22, 2017

Sija commented Sep 22, 2017

Sija commented Sep 22, 2017 • edited Loading

aurimasniekis commented Sep 22, 2017

Sija Sep 24, 2017

Choose a reason for hiding this comment

aurimasniekis Sep 24, 2017

Choose a reason for hiding this comment

Sija Sep 24, 2017 • edited Loading

Choose a reason for hiding this comment

Sija Sep 24, 2017

Choose a reason for hiding this comment

aurimasniekis Sep 24, 2017

Choose a reason for hiding this comment

bew Sep 24, 2017

Choose a reason for hiding this comment

aurimasniekis Oct 6, 2017

Choose a reason for hiding this comment

Sija commented Oct 4, 2017

ysbaddaden commented Oct 5, 2017

aurimasniekis commented Oct 6, 2017

aurimasniekis commented Oct 6, 2017

Sija commented Oct 6, 2017

aurimasniekis commented Oct 6, 2017

Willamin commented Apr 2, 2018

kingsleyh commented Jun 3, 2018

straight-shoota commented Jan 23, 2021

Added `pkcs5_pbkdf2_hmac` to `lib_crypto.cr` and `pkcs5.cr` #5021

Added `pkcs5_pbkdf2_hmac` to `lib_crypto.cr` and `pkcs5.cr` #5021

aurimasniekis commented Sep 22, 2017 •

edited

Loading

Sija commented Sep 22, 2017 •

edited

Loading

Sija Sep 24, 2017 •

edited

Loading