Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hplip: 3.16.11 -> 3.17.9 #29666

Merged
merged 3 commits into from Sep 25, 2017
Merged

hplip: 3.16.11 -> 3.17.9 #29666

merged 3 commits into from Sep 25, 2017

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Sep 22, 2017 •
edited

Motivation

I have tested the binary plugin driver and the Postscript driver.

Testing

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ttuegel
hplip: remove 3.15.9
4c09aca 
hplip-3.15.9 has not been buildable in some time due to changes in CUPS.
@ttuegel
hplip: 3.16.11 -> 3.17.9
ec62d54 
hplip-3.16.11 is retained as `hplip_3_16_11`.
@ttuegel
hplip: change maintainers
a2b852c 
Remove nckx and add ttuegel
@ttuegel ttuegel self-assigned this Sep 22, 2017
@mention-bot
Copy link

@ttuegel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nckx, @FRidh and @urkud to be potential reviewers.

@jgeerds
Copy link
Member

jgeerds commented Sep 24, 2017

@ttuegel: Your changes looks good to me. Unfortunately I don't have the time to test your changes.

Could someone else help out? @nckx?

@nckx
Copy link
Member

nckx commented Sep 24, 2017

I'm certainly willing to test this, but since

  • that'll be in exactly 48 hours,
  • will be only on x86* anyway, and
  • I trust @ttuegel to do good work,

I don't expect anyone to actually wait for me.

@ttuegel
Copy link
Member Author

ttuegel commented Sep 25, 2017

I don't expect anyone to actually wait for me.

I will go ahead with merging into master. I think this should eventually be ported to NixOS 17.09 because it adds support for new printer models. I will wait on that until we are sure it's stable.

@ttuegel ttuegel merged commit 8036ee5 into NixOS:master Sep 25, 2017
@ttuegel ttuegel deleted the hplip branch September 25, 2017 15:22
@eqyiel
Copy link
Contributor

eqyiel commented Sep 25, 2017

I gave this a go and Gnome was able to see my printer. Thanks!

@stefano-m
Copy link
Contributor

@ttuegel any idea when this will be ported to NixOS 17.09? It would be a life-saver for me as at the moment I cannot use my printer.

Thanks!

@ajs124 ajs124 mentioned this pull request Jan 21, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nckx nckx Awaiting requested review from nckx

@jgeerds jgeerds Awaiting requested review from jgeerds

Assignees

@ttuegel ttuegel

Labels
6.topic: printing 8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ttuegel @mention-bot @jgeerds @nckx @eqyiel @stefano-m