Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CompCert #29642

Merged
merged 2 commits into from Sep 21, 2017
Merged

Update CompCert #29642

merged 2 commits into from Sep 21, 2017

Conversation

Zimmi48
Copy link
Member

@Zimmi48 Zimmi48 commented Sep 21, 2017

Motivation for this change

This update allows to unpin the version of Coq (3.0.1 required exactly 8.6).
See commit messages for details.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests) (N/A)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Note that the fix of the VERSION file can likely be removed at the next update.
The license of CompCert is not a generic "INRIA" license. It is "INRIA Non-Commercial
Agreement for the CompCert verified compiler". As unfortunate as it may seem, this
is a non-free license (clearly mentioned as such in its preamble). See also NixOS#20256.
@mention-bot
Copy link

@Zimmi48, thanks for your PR! By analyzing the history of the files in this pull request, we identified @thoughtpolice, @vcunat and @edolstra to be potential reviewers.

@Mic92 Mic92 merged commit e5b97e3 into NixOS:master Sep 21, 2017
@Mic92
Copy link
Member

Mic92 commented Sep 21, 2017

Thanks!

@Zimmi48 Zimmi48 deleted the update-compcert branch September 21, 2017 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants