Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update firefox.syncserver and its dependencies #30594

Closed
wants to merge 6 commits into from
Closed

Update firefox.syncserver and its dependencies #30594

wants to merge 6 commits into from

Conversation

Nadrieril
Copy link
Member

Motivation for this change

Update; also fixes compatibility with recent versions of Firefox Android.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Nadrieril Nadrieril requested a review from FRidh as a code owner October 19, 2017 22:20
FRidh
FRidh requested changes Oct 22, 2017
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • commit per package
  • can you move the expressions to python-modules/<package>/default.nix.

@Nadrieril
Copy link
Member Author

@FRidh I'm not sure I understand your first point: do you want one PR per package ?

@Nadrieril
Copy link
Member Author

@FRidh Does this look good to you ?

@FRidh
Copy link
Member

FRidh commented Feb 3, 2018

Yep, thanks. Pushed d1e2159.

@FRidh FRidh closed this Feb 3, 2018
@FRidh
Copy link
Member

FRidh commented Feb 3, 2018

Some other expressions should have actually been moved as well...but..well that's for next time.

@Nadrieril Nadrieril deleted the update-ffsync branch February 7, 2018 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Nadrieril @FRidh @GrahamcOfBorg