Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenBSD support (WIP) #551

Closed
wants to merge 1 commit into from
Closed

Add OpenBSD support (WIP) #551

wants to merge 1 commit into from

Conversation

ibara
Copy link

@ibara ibara commented Oct 20, 2017

Hi --

This pull request will provide support for zig on OpenBSD. It is a work-in-progress right now; the syscall parts need to be finished up.

@andrewrk
Copy link
Member

ooh this is exciting. looks really good so far. let me know if you have any questions or suggestions.

@andrewrk
Copy link
Member

Also note: since we have lazy top level declarations, this code that you're adding is strictly an improvement, so as far as I'm concerned it's already good to merge, and we can keep working on getting closer towards all tests passing on OpenBSD.

@ibara
Copy link
Author

ibara commented Oct 20, 2017

My guess is at the moment OpenBSD will just fail spectacularly since it will try to access Linux syscalls (which of course don't map onto OpenBSD syscalls at all). But if you think it's good enough to import, great, and I'll keep on working on this.

@andrewrk
Copy link
Member

My mistake. I assumed that you had looked up the syscalls for OpenBSD.

I would like to follow a different approach for development, which is, start with nothing, instead of starting with an incorrect copy, and slowly grow the nothing into complete OpenBSD support.

It's too error prone to start with an incorrect copy and then try to remember to fix everything. Let the errors be compile errors for missing functions.

@ibara
Copy link
Author

ibara commented Oct 20, 2017

The Linux skeleton was for me to ensure proper coding style for you. I'm ok with starting with nothing and building up.

That's why I mentioned this is a WIP :). I won't ask to have this committed until I'm finished with at least amd64 (I assume there's a reason you have disabled i386 on Linux, and I simply followed suit).

@andrewrk
Copy link
Member

andrewrk commented Oct 21, 2017

(I assume there's a reason you have disabled i386 on Linux, and I simply followed suit).

Before I had travis set up to test automatically, i386 support bit rotted, so I disabled it. When 32 bit support is desired we can work on getting it back up to speed.

Which reminds me, one thing we should figure out as part of OpenBSD support is how to test it. Even if we don't get some kind of continuous integration going, however, we can at least verify that the tests compile for OpenBSD by adding it to the cross compile matrix.

@andrewrk
Copy link
Member

I'm going to go ahead and close this, please re-open when you want me to review some code 👍

@andrewrk andrewrk closed this Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants