Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sudo and sssd: Enable sssd support in sudo and building of sudo library in sssd #30025

Closed
wants to merge 18 commits into from
Closed

Conversation

lejonet
Copy link
Contributor

@lejonet lejonet commented Oct 2, 2017

Motivation for this change

Sudo has support to poll SSSD for its sudoers rules, but it has to be compiled into sudo and it requires a sudo plugin, libsss_sudo.so, from SSSD to function.

Added optional arguments to sudo and sssd to enable this functionality and have tested it, via packageOverrides, on a baremetal nixos machine. Both sssd and sudo was built with nix.useSandbox = true and I tried the functionality it brings and it works, I have sudoers rules in an openldap directory which I could apply after appending sudoers: files sss to nsswitch.conf.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bjornfor
Copy link
Contributor

Hi, could you move this PR to a separate feature branch? It seems you are using your master branch, and now you have added some non-relevant commits to this PR. (All the "sheepdog" stuff.)

@lejonet
Copy link
Contributor Author

lejonet commented Oct 15, 2017

Definitively, was a while since I did the PR workflow, so completely missed that

@lejonet
Copy link
Contributor Author

lejonet commented Oct 15, 2017

Seems like I can't change from what branch I want to merge, but I can change to which branch I want to merge, so I'll close this PR and open up a new with the correct branch.

@bjornfor
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants