Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r-modules: Fix a number of popular R packages #30625

Merged
merged 1 commit into from
Oct 21, 2017

Conversation

hamishmack
Copy link
Contributor

Motivation for this change

We tried to build around 1000 of the top CRAN packages (by download). Some of them had build errors and and this pull request fixes many of those.

The R V8 package still depends on V8 3.14 so this is also included.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

The R V8 package still depends on V8 3.14 so this is also included.
@hamishmack hamishmack requested a review from peti as a code owner October 21, 2017 01:26
@domenkozar domenkozar merged commit 8870d1a into NixOS:master Oct 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants