Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow chaining Array methods #5154

Merged
merged 1 commit into from Oct 20, 2017
Merged

Allow chaining Array methods #5154

merged 1 commit into from Oct 20, 2017

Conversation

maxpowa
Copy link
Contributor

@maxpowa maxpowa commented Oct 20, 2017

Modifies Array based on discussion in #4994. Array#reject!, Array#select!, and Array#compact! now return self in all scenarios to support chaining.

@maxpowa
Allow chaining Array methods
e936233 
Modifies Array based on discussion in crystal-lang#4994. `Array#reject!`, `Array#select!`, and `Array#compact!` now return self in all scenarios.
asterite
asterite approved these changes Oct 20, 2017
View reviewed changes
Copy link
Member

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@asterite asterite merged commit 7bbb400 into crystal-lang:master Oct 20, 2017
@asterite asterite added this to the Next milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
breaking-change kind:refactor topic:stdlib
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maxpowa @asterite @RX14