Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.camlp5: 7.01 -> 7.02 #30268

Merged
merged 1 commit into from Oct 17, 2017
Merged

ocamlPackages.camlp5: 7.01 -> 7.02 #30268

merged 1 commit into from Oct 17, 2017

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Oct 10, 2017 •
edited

Motivation for this change

Camlp5 version 7.01 does not work with OCaml 4.06

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distribution
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@vbgl vbgl merged commit 182b357 into NixOS:master Oct 17, 2017
@vbgl vbgl deleted the camlp5-7.02 branch November 14, 2019 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@vbgl