Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.ofxhome: 0.3.1 -> 0.3.3 #30263

Merged
merged 1 commit into from Mar 18, 2018
Merged

pythonPackages.ofxhome: 0.3.1 -> 0.3.3 #30263

merged 1 commit into from Mar 18, 2018

Conversation

tsaeger
Copy link
Contributor

@tsaeger tsaeger commented Oct 10, 2017

Motivation for this change

Update to latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@tsaeger tsaeger requested a review from FRidh as a code owner October 10, 2017 02:36
FRidh
FRidh reviewed Oct 10, 2017
View reviewed changes
pkgs/top-level/python-packages.nix Outdated
@@ -24794,10 +24794,10 @@ EOF
};

ofxhome = buildPythonPackage rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move this expression. See the header of this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Please take a look at new commit.

@gebner
Copy link
Member

gebner commented Mar 18, 2018

@GrahamcOfBorg build python2Packages.ofxclient python3Packages.ofxclient

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2Packages.ofxclient, python3Packages.ofxclient

Partial log (click to expand)

/build/ofxclient-2.0.3
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/j9fpxqrw0gkj0q7hhcmwncywpc4yjk3w-python3.6-ofxclient-2.0.3
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/j9fpxqrw0gkj0q7hhcmwncywpc4yjk3w-python3.6-ofxclient-2.0.3/lib  /nix/store/j9fpxqrw0gkj0q7hhcmwncywpc4yjk3w-python3.6-ofxclient-2.0.3/bin
patching script interpreter paths in /nix/store/j9fpxqrw0gkj0q7hhcmwncywpc4yjk3w-python3.6-ofxclient-2.0.3
checking for references to /build in /nix/store/j9fpxqrw0gkj0q7hhcmwncywpc4yjk3w-python3.6-ofxclient-2.0.3...
wrapping `/nix/store/j9fpxqrw0gkj0q7hhcmwncywpc4yjk3w-python3.6-ofxclient-2.0.3/bin/ofxclient'...
/nix/store/l27927zs0m23azdhjcpa1fy09cjzqp6w-python2.7-ofxclient-2.0.3
/nix/store/j9fpxqrw0gkj0q7hhcmwncywpc4yjk3w-python3.6-ofxclient-2.0.3

@gebner gebner merged commit 9a49811 into NixOS:master Mar 18, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2Packages.ofxclient, python3Packages.ofxclient

Partial log (click to expand)

/build/ofxclient-2.0.3
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qsm3dhh2y51hsqykk690575a68vfm78i-python3.6-ofxclient-2.0.3
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/qsm3dhh2y51hsqykk690575a68vfm78i-python3.6-ofxclient-2.0.3/lib  /nix/store/qsm3dhh2y51hsqykk690575a68vfm78i-python3.6-ofxclient-2.0.3/bin
patching script interpreter paths in /nix/store/qsm3dhh2y51hsqykk690575a68vfm78i-python3.6-ofxclient-2.0.3
checking for references to /build in /nix/store/qsm3dhh2y51hsqykk690575a68vfm78i-python3.6-ofxclient-2.0.3...
wrapping `/nix/store/qsm3dhh2y51hsqykk690575a68vfm78i-python3.6-ofxclient-2.0.3/bin/ofxclient'...
/nix/store/lhzrxirws3d25fnbdzvmw35n3zxysm3f-python2.7-ofxclient-2.0.3
/nix/store/qsm3dhh2y51hsqykk690575a68vfm78i-python3.6-ofxclient-2.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tsaeger @gebner @GrahamcOfBorg @FRidh @c0bw3b