Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.ofxclient: 1.3.8 -> 2.0.3 #30264

Merged
merged 1 commit into from Oct 28, 2017
Merged

pythonPackages.ofxclient: 1.3.8 -> 2.0.3 #30264

merged 1 commit into from Oct 28, 2017

Conversation

tsaeger
Copy link
Contributor

@tsaeger tsaeger commented Oct 10, 2017

Motivation for this change

Update to latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@tsaeger tsaeger requested a review from FRidh as a code owner October 10, 2017 02:38
@FRidh
Copy link
Member

FRidh commented Oct 10, 2017

can you move this expression. See the header of this file.

@tsaeger
Copy link
Contributor Author

tsaeger commented Oct 10, 2017

Fixed as requested.

Bump.

@FRidh
Copy link
Member

FRidh commented Oct 18, 2017

How does this affect ledger-autosync?

@FRidh FRidh merged commit dcff3cc into NixOS:master Oct 28, 2017
@grahamc
Copy link
Member

grahamc commented Nov 14, 2017 •
edited

Can we get this and #30948 backported? It seems ofxclient is broken on 17.09, according to reports from @roymarantz.

@tsaeger
Copy link
Contributor Author

tsaeger commented Nov 14, 2017

@grahamc backport and send a separate pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tsaeger @FRidh @grahamc