Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.req: fix build, update default version #29950

Closed
wants to merge 2 commits into from
Closed

haskellPackages.req: fix build, update default version #29950

wants to merge 2 commits into from

Conversation

wldhx
Copy link
Member

@wldhx wldhx commented Sep 30, 2017 •
edited

Motivation for this change

haskellPackages.req doesn't build due to upstream's failing tests; default package version is outdated.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@wldhx wldhx requested a review from peti as a code owner September 30, 2017 11:56
peti
peti requested changes Sep 30, 2017
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't edit this file. It says so at the very top, btw. This file is auto-generated and any changes you make there will be lost the next time we update. Also, note that the version of req we use by default is determined by LTS Haskell 9.x and we won't perform an update that breaks API compatibility lightly.

@peti peti closed this Sep 30, 2017
peti added a commit to NixOS/cabal2nix that referenced this pull request Sep 30, 2017
@peti
req: disable failing test suite
5a860e4 
Fixes NixOS/nixpkgs#29950.
@peti
Copy link
Member

peti commented Sep 30, 2017

I disabled the test suite in NixOS/cabal2nix@5a860e4. The new version of the build will arrive in master within a few days.

@wldhx
Copy link
Member Author

wldhx commented Sep 30, 2017

@peti re: edit, sorry, I just grepped through. Shall be more diligent next time.

Thanks for detailed comments and a quick update.

@wldhx wldhx deleted the dev-haskellPackages.req branch September 30, 2017 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti requested changes

Assignees
No one assigned
Labels
12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wldhx @peti @Janik-Haag