Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure the resource_partitioner is properly destructed on hpx::finalize #2919

Merged
merged 2 commits into from Oct 2, 2017
Merged

Make sure the resource_partitioner is properly destructed on hpx::finalize #2919

merged 2 commits into from Oct 2, 2017

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Sep 30, 2017

@hkaiser hkaiser added this to the 1.1.0 milestone Sep 30, 2017
@hkaiser
Copy link
Member Author

hkaiser commented Sep 30, 2017

@msimberg please verify whether this solves the issue you reported

msimberg
msimberg reviewed Oct 2, 2017
View reviewed changes
tests/regressions/multiple_init_2918.cpp Outdated
@@ -0,0 +1,40 @@
// Copyright (c) 20017 msimberg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be 2017 Mikael Simberg.

@msimberg
Copy link
Contributor

msimberg commented Oct 2, 2017

@hkaiser Yes, thank you, this does solve the issue.

biddisco
biddisco approved these changes Oct 2, 2017
View reviewed changes
Copy link
Contributor

@biddisco biddisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to be pretty thorough. Thanks @hkaiser

@biddisco
Copy link
Contributor

biddisco commented Oct 2, 2017 •
edited

This failed on circle CI - but only because the hpx:bind=none was fixed on another branch and not included in this build. I think it's safe to merge.

@biddisco biddisco merged commit b037eab into master Oct 2, 2017
@biddisco biddisco deleted the fixing_2918 branch October 2, 2017 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg msimberg left review comments

@biddisco biddisco biddisco approved these changes

Assignees
No one assigned
Labels
category: init type: enhancement
Projects
resource partitioner/manager work
completed
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

hpx::init calls wrong (first) callback when called multiple times
3 participants
@hkaiser @msimberg @biddisco